Skip to content

Rollup of 2 pull requests#154909

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-44bqfTG
Apr 6, 2026
Merged

Rollup of 2 pull requests#154909
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-44bqfTG

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer commented Apr 6, 2026

Successful merges:

r? @ghost

Create a similar rollup

@rust-bors rust-bors bot added the rollup A PR which is a rollup label Apr 6, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

JonathanBrouwer commented Apr 6, 2026

@bors r+ rollup=never p=5

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 6, 2026

📌 Commit 4be8f65 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 6, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 6, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 7m 57s
Pushing bcded33 to main...

@rust-bors rust-bors bot merged commit bcded33 into rust-lang:main Apr 6, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 6, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 6, 2026

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#154875 Avoid duplicate diagnostic args in `RegionOriginNote::WithN… 1e16e8c870b618de7a1c31d6243d7c8920989a95 (link)
#154898 Use debug! instead of info! 31de93b4a2e1180d7970fef9217f5972aee7299c (link)

previous master: a92a99ef14

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a92a99e (parent) -> bcded33 (this PR)

Test differences

Show 20 test diffs

Stage 1

  • [ui] tests/ui/regions/impl-trait-lifetime-conflict-hashmap-keys.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/regions/impl-trait-lifetime-conflict-hashmap-keys.rs: [missing] -> pass (J0)

Additionally, 18 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bcded331651b60a0383b3ff51db4f24c4495ac53 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 27m 59s -> 33m (+17.9%)
  2. tidy: 2m 24s -> 2m 48s (+16.7%)
  3. arm-android: 1h 33m -> 1h 48m (+16.2%)
  4. test-various: 1h 49m -> 2h 6m (+16.1%)
  5. dist-apple-various: 1h 21m -> 1h 32m (+13.4%)
  6. dist-aarch64-msvc: 1h 46m -> 2h (+13.1%)
  7. i686-gnu-2: 1h 32m -> 1h 44m (+12.4%)
  8. dist-powerpc-linux: 1h 23m -> 1h 33m (+12.0%)
  9. x86_64-gnu-tools: 56m 20s -> 1h 2m (+11.6%)
  10. optional-x86_64-gnu-parallel-frontend: 2h 22m -> 2h 37m (+10.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Bryntet Bryntet deleted the rollup-44bqfTG branch April 6, 2026 23:27
@rust-timer
Copy link
Copy Markdown
Collaborator

rust-timer commented Apr 6, 2026

Finished benchmarking commit (bcded33): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 5.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.5% [5.5%, 5.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 8.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 8.2% [5.6%, 10.9%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 487.739s -> 486.041s (-0.35%)
Artifact size: 395.17 MiB -> 395.29 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer @rust-timer @rustbot @TaKO8Ki @mejrs